]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
StWidget: don't dispose the theme node when destroyed
authorGiovanni Campagna <gcampagna@src.gnome.org>
Mon, 26 Nov 2012 21:56:22 +0000 (22:56 +0100)
committerGiovanni Campagna <gcampagna@src.gnome.org>
Mon, 26 Nov 2012 21:59:22 +0000 (22:59 +0100)
Theme nodes are interned and shared with other widgets, so they cannot
be disposed, otherwise we blow useful resources, and in particular we
break the parent-child chain.

https://bugzilla.gnome.org/show_bug.cgi?id=689029

src/st/st-widget.c

index b1218d3fb2b108dcf5fb6ea8f974bc5313ac22ac..65de2722b828ca744b8965f24a46f85197b911f1 100644 (file)
@@ -316,7 +316,6 @@ st_widget_dispose (GObject *gobject)
 
   if (priv->theme_node)
     {
-      g_object_run_dispose (G_OBJECT (priv->theme_node));
       g_object_unref (priv->theme_node);
       priv->theme_node = NULL;
     }